react-doctor/button-has-type
Set type="button" (or "submit"/"reset") explicitly on every <button> so it never defaults to submit.
- Status
- Active
- Category
- Correctness
- Assessment
- Evidence-required risk
- Required evidence
- source code
- Default configuration
- Enabled
- Default severity
- warn
Show technical metadata
- Scope
- All supported frameworks
- Active when
- always
- Requirements
- react
- Priority
- 46 (P3)
- Source
- oxlint-plugin-react-doctor
- Rule set
- oxlint-plugin-react-doctor 0.9.3 (prompt schema 2)
- Documentation
- Official documentation
Validation prompt
Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.
Fires on a <button> (or React.createElement("button", …)) that has no type, has bare type shorthand (= type={true}), or whose type cannot be statically proven to be one of the enabled values button/submit/reset: covering type="foo", type={foo} identifiers, dynamic template literals like type={button${x}}, and conditionals where any branch isn't a proven-valid literal. Test/Storybook-like filenames are skipped entirely, and disabling an option (e.g. reset:false) makes that value fire.
Suppress when: this isn't one: consumer prop-forwarding wrappers (type={type}, type={props.type}, type={type ?? "button"}) are deliberately NOT flagged because the diagnostic is meant to fire at the consumer's literal call site, so don't suppress those expecting the rule; do confirm any concrete non-allowed or missing literal.
Evidence boundary
The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.
Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.
Record one outcome:
- Confirmed failure: The required evidence establishes the violation.
- Rejected: A documented exception or false-positive predicate applies.
- Needs evidence: Named evidence can still be collected.
- Unavailable: Required evidence cannot be collected in this run.
- Waived with evidence: An authorized, scoped exception applies to an established failure.
- Observation: The review records an optional tradeoff without claiming a defect.
A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.
Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.
Fix prompt
Apply this candidate correction only after the required evidence confirms the risk.
Add an explicit, statically valid type to the button: <button type="button"> for ordinary click handlers, type="submit" only for the form's primary submit, or type="reset". For dynamic values, ensure every branch resolves to a literal in the allowed set (type={primary ? "submit" : "button"}) rather than an identifier or interpolated template, and apply the same to React.createElement("button", { type: "button" }). See https://oxc.rs/docs/guide/usage/linter/rules/react/button-has-type
Repository-wide copy prompt
Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.
Show repository-wide prompt
Fix every confirmed react-doctor/button-has-type diagnostic in the current repository.
Required change:
- Add an explicit, statically valid
typeto the button:<button type="button">for ordinary click handlers,type="submit"only for the form's primary submit, ortype="reset". For dynamic values, ensure every branch resolves to a literal in the allowed set (type={primary ? "submit" : "button"}) rather than an identifier or interpolated template, and apply the same toReact.createElement("button", { type: "button" }). See https://oxc.rs/docs/guide/usage/linter/rules/react/button-has-type.
Validation before editing:
Fires on a <button> (or React.createElement("button", …)) that has no type, has bare type shorthand (= type={true}), or whose type cannot be statically proven to be one of the enabled values button/submit/reset: covering type="foo", type={foo} identifiers, dynamic template literals like type={button${x}}, and conditionals where any branch isn't a proven-valid literal. Test/Storybook-like filenames are skipped entirely, and disabling an option (e.g. reset:false) makes that value fire.
Suppress when: this isn't one: consumer prop-forwarding wrappers (type={type}, type={props.type}, type={type ?? "button"}) are deliberately NOT flagged because the diagnostic is meant to fire at the consumer's literal call site, so don't suppress those expecting the rule; do confirm any concrete non-allowed or missing literal.
Constraints:
- Make the smallest change that fixes the root cause.
- Preserve behavior and interfaces unrelated to this diagnostic.
- Reuse existing project components, utilities, and conventions.
- Do not introduce render-phase side effects, render-phase state updates, or Hooks rule violations.
- Adapt identifiers and framework details instead of copying blindly.
- Do not disable the rule or suppress matching code.
Assessment:
- Record detector evidence, applicability facts, assumptions, missing evidence, and the rule class for this occurrence.
- Return one outcome: Confirmed failure, Rejected, Needs evidence, Unavailable, Waived with evidence, or Observation.
- A waiver records the established failure, scope, authority, evidence, and review or expiry condition. It is not a pass or false positive.
Verification:
- Run focused tests for the changed behavior.
- Run React Doctor and confirm this diagnostic no longer appears from changed code.
- Run an unfiltered scan of the affected scope before claiming no cross-category regression.
- Report the files changed and any checks you could not run.