react-doctor/no-effect-with-fresh-deps

Move the constructed value into the hook body and depend on its primitive inputs, or memoize it with useMemo/useCallback so its reference is stable.

Validation prompt

Confirm the detector match and collect the required evidence before deciding whether an edit is warranted.

Fires on a hook in HOOKS_WITH_DEPS (useEffect, useLayoutEffect, useMemo, useCallback, also via React.useEffect) whose SECOND argument is an ArrayExpression containing an element that is, or resolves to, a freshly-allocated reference: a direct ObjectExpression, ArrayExpression, Arrow/FunctionExpression, JSXElement/JSXFragment, or NewExpression at the dep site; OR an Identifier whose binding is an UNCONDITIONAL VariableDeclarator init (const/let/var name = {...}/[...]/() => …/new …) in the same component scope. Such elements break the element-wise === (Object.is) comparison so the effect/memo re-runs every render.

Suppress when: do NOT flag plain identifiers, member expressions like options.value, deps from useMemo/useCallback/useRef/useState/useReducer or any CallExpression including custom hooks (treated as opaque), bindings declared at module/Program scope (allocated once), destructuring or parameter DEFAULTS such as function List({ items = [] }) or const { config = {} } = props (the default only allocates when the source is undefined and can't be hoisted), spread elements [...arr], empty deps [], or effects with no deps array at all (running every render is intentional there).

Evidence boundary

The diagnostic proves only that the detector’s modeled source pattern matched. It does not prove runtime impact, product intent, rendered failure, or that one remediation is correct.

Establish the environment, repository policy, exceptions, and required rendered or runtime evidence before deciding the occurrence.

Record one outcome:

• Confirmed failure: The required evidence establishes the violation.
• Rejected: A documented exception or false-positive predicate applies.
• Needs evidence: Named evidence can still be collected.
• Unavailable: Required evidence cannot be collected in this run.
• Waived with evidence: An authorized, scoped exception applies to an established failure.
• Observation: The review records an optional tradeoff without claiming a defect.

A waiver records its scope, authority, evidence, and review condition. It is not a pass or false positive.

Default severity is registry metadata. Use the occurrence’s JSON severity after repository configuration when ordering real findings.

Fix prompt

Apply this candidate correction only after the required evidence confirms the risk.

The flagged dep element is reallocated every render so its === comparison always fails and the hook fires each render. If the value is only used inside the hook, delete it from the dep array and construct it inside the hook body, depending instead on its primitive inputs (e.g. useEffect(() => { const config = { a, b }; … }, [a, b])). If it must be shared, stabilize its reference with const config = useMemo(() => ({ a, b }), [a, b]) or const handler = useCallback(() => …, [deps]) and depend on that, or hoist a truly-constant value to module scope. See https://react.dev/reference/react/useEffect#removing-unnecessary-object-dependencies

Repository-wide copy prompt

Use this repository-wide prompt only after validating each occurrence. For one occurrence, use the guidance above.